[Build-common-hackers] Bug#582693: Bug#582693: Support cdbs_curpkg for DEB_DH_INSTALLINIT_ARGS

Jonas Smedegaard jonas at jones.dk
Sat May 22 20:55:22 UTC 2010


On Thu, May 20, 2010 at 03:33:52PM -0500, Rudy Godoy wrote:

>Please add cdbs_curpkg for DEB_DH_INSTALLINIT_ARGS. Currently it
>does apply for each target binary package.

Ah, stupid me [asking for a patch without noticing that indeed you 
already provided one] :-P

Thanks for the patch!  It is flawed, so a good example of how small 
changes can go bad: You _replace_ DEB_DH_INSTALLINIT_ARGS with the 
package-specific variant of it.  The proper would be to still use 
DEB_DH_INSTALLINIT_ARGS as fallback.

But flawed or not - it helps me more clearly understand exactly what is 
your needs.  Now I'll do my best to fix it to not hurt potential needs 
of others. :-)

...and while we are at it: It won't hurt to also add an *_ALL variant 
which is always applied, in addition to either the main variable or the 
package-specific override.  I.e. use the (also recently added) 
cdbs_expand_curvar.


Regards,

  - Jonas

-- 
  * Jonas Smedegaard - idealist & Internet-arkitekt
  * Tlf.: +45 40843136  Website: http://dr.jones.dk/

  [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20100522/a8c1a4ac/attachment-0001.pgp>


More information about the Build-common-hackers mailing list