[Build-common-hackers] Bug#598410: cdbs: Does not handle parent directories with spaces

[Michael Terry]

Package: cdbs
Version: 0.4.83ubuntu2
Severity: normal
Tags: patch
User: ubuntu-devel at lists.ubuntu.com
Usertags: origin-ubuntu maverick ubuntu-patch

A bug with the Ubuntu version of cdbs was found where parent directories with
spaces prevented python-distutils packages from working.  Specifically,
the --root option to setup.py needed to be quoted.

https://bugs.launchpad.net/ubuntu/+source/cdbs/+bug/636277

I'm attaching the patch I came up with to solve it for me here.

-- System Information:
Debian Release: squeeze/sid
  APT prefers maverick-updates
  APT policy: (500, 'maverick-updates'), (500, 'maverick-security'), (500, 'maverick')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.35-22-generic (SMP w/4 CPU cores)
Locale: LANG=en_GB.utf8, LC_CTYPE=en_GB.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages cdbs depends on:
ii  debhelper                   8.0.0ubuntu1 helper programs for debian/rules
ii  fdupes                      1.50-PR2-3   identifies duplicate files within 
ii  intltool                    0.41.1-1     Utility scripts for internationali

Versions of packages cdbs recommends:
ii  autotools-dev                 20100122.1 Update infrastructure for config.{

Versions of packages cdbs suggests:
ii  devscripts                2.10.67ubuntu1 scripts to make the life of a Debi
ii  doc-base                  0.9.5          utilities to manage online documen

-- debconf-show failed
-------------- next part --------------
=== modified file '1/class/python-distutils.mk.in'
--- 1/class/python-distutils.mk.in	2010-05-03 09:55:59 +0000
+++ 1/class/python-distutils.mk.in	2010-09-28 19:45:09 +0000
@@ -72,13 +72,13 @@
 
 # install stage
 $(patsubst %,install/%,$(cdbs_python_indep_packages)) :: install/%: python-install-py
-	cd $(DEB_SRCDIR) && python$(cdbs_python_nondefault_version) $(DEB_PYTHON_SETUP_CMD) install --root=$(cdbs_python_destdir) \
+	cd $(DEB_SRCDIR) && python$(cdbs_python_nondefault_version) $(DEB_PYTHON_SETUP_CMD) install --root="$(cdbs_python_destdir)" \
 		--install-purelib=/usr/lib/python$(or $(cdbs_python_nondefault_version),$(cdbs_python_current_version))/site-packages/ $(DEB_PYTHON_INSTALL_ARGS_ALL)
 
 $(patsubst %,install/%,$(cdbs_python_arch_packages)) :: install/%: $(addprefix python-install-, $(cdbs_python_build_versions))
 	set -e; for buildver in $(cdbs_python_build_versions); do \
 		cd $(CURDIR) && cd $(DEB_SRCDIR) && $(call cdbs_python_binary,python$$buildver) $(DEB_PYTHON_SETUP_CMD) install \
-		--root=$(cdbs_python_destdir) --install-purelib=/usr/lib/python$$buildver/site-packages/ \
+		--root="$(cdbs_python_destdir)" --install-purelib=/usr/lib/python$$buildver/site-packages/ \
 		--install-platlib=/usr/lib/python$$buildver/site-packages/ $(DEB_PYTHON_INSTALL_ARGS_ALL); \
 	done