[Build-common-hackers] waf.mk and broken fakeroot debian/rules clean call in packaging-only branches.

[Emilio Pozuelo Monfort]

On 30/03/11 11:24, Jonas Smedegaard wrote:
>>  [ ! -f Makefile ] || $(MAKE) distclean

> I therefore agree that we should try(!) to handle gracefully the waf file
> missing (thanks for insisting, Krzysztof!), but I disagree that we whould do it
> by simply adding a leading dash.

So something like e.g.

[ ! -f waf ] || ./waf clean

(or however waf clean is called, I'm not familiar with it).

Sounds good to me.

> ...and we should fix the existing too relaxed snippets while at it.

I'm fine with that too, as long as we keep supporting `debclean' with only a
debian/ folder (this is the usual way to do packaging with svn-buildpackage, and
there are probably 1000+ packages in the archive packaged that way).

> I imagine introducing a new variables DEB_CLEAN_RELAX and DEB_CLEAN_RELAX_PREFIX
> (inherited as e.g. DEB_MAKE_CLEAN_RELAX and DEB_MAKE_CLEAN_...,
> DEB_SCONS_CLEAN_... etc. to allow mixing classes and override only some of
> them).  The content of ...RELAX_PREFIX is then prefixed relevant clean rules
> when ...RELAX is non-empty.
> 
> I fear this will trigger a pile of FTBFS so wonder how to best proceed.
> 
> a) DEB_CLEAN_RELAX=1 by default
> b) DEB_CLEAN_RELAX=1 by default with warning until weezy release
> c) DEB_CLEAN_RELAX unset by default
> 
> 
> What do you think?

I'm not too sure what changes you mean that would cause FTBFS. Can you say a
real example?

> Please respect the dual CC as requested by Krzysztof!

The CC wasn't in his mail.

Cheers,
Emilio