[Build-common-hackers] Bug#651964: Bug#651964: cdbs: class/langcore.mk doesn't set CPPFLAGS and LDFLAGS from dpkg-buildflags

[Jonas Smedegaard]

tags 651964 wontfix
thanks

On 11-12-13 at 05:34pm, Simon Ruderich wrote:
> While trying to build poppler with hardening flags I noticed that 
> CPPFLAGS and LDFLAGS were not set correctly. This is an important 
> problem as it causes several hardening flags (fortify source, relro) 
> to not get included in the build.
> 
> Adding the following lines to class/langcore.mk.in in line 57 where 
> CFLAGS and CXXFLAGS are already set fixes the problem:
> 
>     CPPFLAGS += $(deb_cppflags)
>     LDFLAGS += $(deb_ldflags)


Thanks for your bugreport.

I agree with you that some flags were set properly in the past.  
Unfortunately some packages depend on the old broken behaviour, so it 
can not be corrected now.

You can add the following at the top of your rules file to make CDBS 
handle compile flags more sensibly:

CDBS_FIX_COMPILE_FLAGS = 1



Kind regards,

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20111214/b7890db5/attachment.pgp>