[Build-common-hackers] Bug#651966: Bug#651966: class/langcore.mk: DEB_BUILD_MAINT_OPTIONS not passed to dpkg-buildflags

[Raphael Hertzog]

Hi,

On Wed, 14 Dec 2011, Jonas Smedegaard wrote:
> On 11-12-14 at 08:17am, Raphael Hertzog wrote:
> > On Tue, 13 Dec 2011, Simon Ruderich wrote:
> > > The attached patch fixes this and passes DEB_BUILD_MAINT_OPTIONS to 
> > > dpkg-buildflags, but I'm not sure if it's the best way to do it.
> > 
> > The attached patch is not enough. There are other variables that are 
> > important.
> > 
> > Please check /usr/share/dpkg/buildflags.mk as an example of how this 
> > should be done.
> > 
> > Better, I suggest that you rely on dpkg-dev doing the work for you and 
> > that you just include this Makefile and use the standard variables.
> 
> Thanks for your attention to this.
> 
> I am unsure what you suggest above - do you suggest that CDBS not mess 
> with variables at all, or that the proposed patch not be used at all?

I suggest that the patch be reworked to not redo what
/usr/share/dpkg/buildflags.mk already does correctly and to find a way
to reuse /usr/share/dpkg/buildflags.mk.

Unfortunately the interface of /usr/share/dpkg/buildflags.mk means that
CFLAGS/CXXFLAGS/CPPFLAGS/LDFLAGS/FFLAGS are directly modified so you if
you want to store their values in other variables, you might have to backup
the values before including that Makefile and restore them afterwards.

(Of course, if you find this too messy, feel free to find another way to
nicely resolve the problem :-))

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Pre-order a copy of the Debian Administrator's Handbook and help
liberate it: http://debian-handbook.info/liberation/