[Build-common-hackers] Bug#617841: Bug#617841: cdbs: support for exporting multiarch path variable
steve.langasek at canonical.com
Thu Mar 17 05:34:43 UTC 2011
On Wed, Mar 16, 2011 at 09:31:24AM +0100, Jonas Smedegaard wrote:
> On Fri, Mar 11, 2011 at 10:52:08AM -0800, Steve Langasek wrote:
> >Multiarch support is coming to Debian soon. It would be helpful if cdbs
> >would start exporting DEB_HOST_MULTIARCH along with the other standard
> >dpkg-architecture variables. (This variable will only be available once
> >dpkg 1.16.0 is uploaded; however there's no reason for cdbs not to start
> >exporting it now, it will just be empty until dpkg support is in place.)
> Took me some time to get around to looking at this - sorry about that.
> From a brief test it seems that it won't just be empty if
> unsupported but will fail with an exit code 9.
> So seems to me to not make sense to apply your patch as-is: needs to
> at least fail gracefully.
> Can someone perhaps help verify if the following (all on one line)
> is more sensible:
> DEB_HOST_MULTIARCH ?= $(shell dpkg-architecture -qDEB_HOST_MULTIARCH || true)
Why should this exit code matter? Make doesn't care what the return code of
the shell function is, only the output, so the '|| true' is a no-op. I.e.,
it already fails gracefully without needing to spawn an extra subprocess.
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
slangasek at ubuntu.com vorlon at debian.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 828 bytes
Desc: Digital signature
More information about the Build-common-hackers