[Build-common-hackers] Bug#625448: Bug#625448: cdbs: Do not remove copyright_newhints if it contains new information

[Jonas Smedegaard]

On 11-05-03 at 02:35pm, Olivier Aubert wrote:
> When new copyright information is detected by licensecheck, the 
> displayed procedure advises to compare/replace copyright_hints with 
> copyright_newhints. However, if COPYRIGHT_CHECK_STRICT is not set, the 
> copyright_newhints is removed in all cases, which makes the file 
> unavailable for further processing.

> The proposed patch removes the copyright_newhints only if there is no 
> further processing to do.

CDBS previously behaved like your patch proposes, but was changed as the 
"clean" target must properly clean - i.e. not leave behind any noise.

So i doubt the patch is really sensible.  Or that this really is a 
problem, other than one of improving documentation.

How about simply extend the emitted instructions with setting 
COPYRIGHT_CHECK_STRICT=1 and rerunning the pre-build rule?


 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20110503/0da92bca/attachment.pgp>