[Build-common-hackers] Bug#651964: Bug#651964: cdbs: class/langcore.mk doesn't set CPPFLAGS and LDFLAGS from dpkg-buildflags
dr at jones.dk
Wed Mar 7 18:53:24 UTC 2012
On 12-03-07 at 04:44pm, Simon Ruderich wrote:
> The problem is a typo in 1/class/langcore.mk.in. The following
> patch fixes it:
> --- cdbs-0.4.105/1/class/langcore.mk.in 2012-03-01 23:06:31.000000000 +0100
> +++ cdbs-0.4.105/1/class/langcore.mk.in 2012-03-07 16:37:32.000000000 +0100
> @@ -56,7 +56,7 @@
> deb_cxxflag := $(call cdbs_expand_nondefaultvar,CXXFLAGS,$(deb_cxxflags))
> deb_ldflags := $(call cdbs_expand_nondefaultvar,LDFLAGS,$(deb_ldflags))
> CFLAGS ?= $(deb_cflags)
> -CPPLAGS ?= $(deb_cppflags)
> +CPPFLAGS ?= $(deb_cppflags)
> CXXFLAGS ?= $(deb_cxxflags)
> LDFLAGS ?= $(deb_ldflags)
> With that change the CPPFLAGS are applied correctly.
If only you knew how many hours I've stared at that code, convinced that
it had to be a simple typo because the logic was perfectly in order for
the other ones.
Thank you, thank you, thank you! Please remind me that I owe you a
bewerage of choice and a cookie, when/if we meet IRL. :-D
> However DEB_BUILD_MAINT_OPTIONS is still not supported (#651966),
> please fix that too.
Yes, I intend to do that. I looked at Raphaels comment but those other
variables seem more like a _different_ way to extend make variables that
I fear clash with CDBS and is not necessary. But let's discuss that at
that bug, not here...
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 836 bytes
Desc: Digital signature
More information about the Build-common-hackers