[Build-common-hackers] Bug#714542: cdbs: Please use "--" long option prefixes for Perl's Module::Build build system

[gregor herrmann]

On Sun, 30 Jun 2013 20:53:41 +0200, Jonas Smedegaard wrote:

> Quoting gregor herrmann (2013-06-30 18:09:26)
> > While packaging Module::Build::Tiny [0], I stumbled about a problem
> > in debhelper which is also present in cdbs. In the perl-build-vars
> > makefile, it uses the key=var type of passing options.
> > 
> > While this works fine with Module::Build which accepts all kinds of
> > styles, if fails with Module::Build::Tiny, which insists on the
> > "--key value" style.
> [snip]
> 
> Thanks for the detailed bugreport and patch.

You're welcome.
 
> > Find attached a patch against 1/class/perl-build-vars.mk.in. I've 
> > tested it by building around a dozen Build.PL using packages with cdbs 
> > and this patch, and I haven't seen any problems.
> As we take pride in CDBS being backporting-friendly, it would be nice if 
> you could also test in a Squeeze (i.e. oldstable) environment that the 
> change doesn't break things that far back either.

Good point. And easy to do with cdbs since it has no rev-deps :)

I've now built ~10 random packges which use cdbs and have a Build.PL
in a squeeze cowbuilder chroot (with the patched cdbs), and all looks
good, options are passed with "--" and everything ends up where it's
supposed to be.


Cheers,
gregor

-- 
 .''`.  Homepage: http://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer  -  http://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Funny Van Dannen: Die Liebe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20130630/e38cbeaa/attachment-0001.sig>