[Build-common-hackers] Bug#724281: Bug#724281: cdbs: license check a lot of time results in an error

[Giulio Paci]

On 23/09/2013 19:42, Jonas Smedegaard wrote:
> I just tried this:
> 
>   git clone git://anonscm.debian.org/collab-maint/sptk
>   cd sptk
>   debian/rules pre-build DEB_MAINTAINER_MODE=1
>   fakeroot debian/rules clean DEB_MAINTAINER_MODE=1
>   debian/copyright_newhints debian/copyright_hints
>   debian/rules pre-build && fakeroot debian/rules clean
> 
> ...which doesn't fail - even repeating last line several times.
> 
> Please provide a minimal set of commands to reproduce.

The first three lines is enough to make the build failing on my system:

$ git clone git://anonscm.debian.org/collab-maint/sptk
Cloning into 'sptk'...
remote: Counting objects: 1450, done.
remote: Compressing objects: 100% (402/402), done.
remote: Total 1450 (delta 1032), reused 1448 (delta 1032)
Ricezione degli oggetti: 100% (1450/1450), 725.48 KiB | 669.00 KiB/s, done.
Risoluzione dei delta: 100% (1032/1032), done.
Checking connectivity... done
Checking out files: 100% (562/562), done.
$ cd sptk
$ debian/rules pre-build DEB_MAINTAINER_MODE=1
dpkg-checkbuilddeps -B
dpkg-checkbuilddeps: Unmet build dependencies: automake1.11
make: [debian/control] Error 1 (ignored)
test -x debian/rules
mkdir -p "."

Scanning upstream source for new/changed copyright notices...

licensecheck -c '.*' -r --copyright -i
'^debian/(changelog|copyright(|_hints|_newhints))' -l '99999' * |
/usr/lib/cdbs/licensecheck2dep5 > debian/copyright_newhints
18 combinations of copyright and licensing found.
ERROR: The following (and possibly more) new or changed notices discovered:

 bin/fig+fdrw/fig.h
License: BSD-3-clause
Copyright: 1992-1999
  1992-1999,
  1992-2001,License: BSD-3-clause
 FIXME

Files: config/install-sh
Copyright: 1994, X Consortium
License: Expat

To fix the situation please do the following:
  1) Fully compare debian/copyright_hints with debian/copyright_newhints
  2) Update debian/copyright as needed
  3) Replace debian/copyright_hints with debian/copyright_newhints
make: *** [debian/stamp-copyright-check] Error 1




And then repeating these three lines (the first one is optional) will
randomly trigger an error:

mv debian/copyright_newhints debian/copyright_hints
fakeroot debian/rules clean DEB_MAINTAINER_MODE=1
debian/rules pre-build DEB_MAINTAINER_MODE=1


$ fakeroot debian/rules clean DEB_MAINTAINER_MODE=1

[...]

$ git status
# Sul branch master
# Changes not staged for commit:
#   (use "git add <file>..." to update what will be committed)
#   (use "git checkout -- <file>..." to discard changes in working
directory)
#
#       modificato:   debian/control
#       modificato:   debian/copyright_hints
#
no changes added to commit (use "git add" and/or "git commit -a")

$ debian/rules pre-build DEB_MAINTAINER_MODE=1
dpkg-checkbuilddeps -B
dpkg-checkbuilddeps: Unmet build dependencies: automake1.11
make: [debian/control] Error 1 (ignored)
test -x debian/rules
mkdir -p "."

Scanning upstream source for new/changed copyright notices...

licensecheck -c '.*' -r --copyright -i
'^debian/(changelog|copyright(|_hints|_newhints))' -l '99999' * |
/usr/lib/cdbs/licensecheck2dep5 > debian/copyright_newhints
17 combinations of copyright and licensing found.
ERROR: The following (and possibly more) new or changed notices discovered:

Copyright: 1992-1999,

To fix the situation please do the following:
  1) Fully compare debian/copyright_hints with debian/copyright_newhints
  2) Update debian/copyright as needed
  3) Replace debian/copyright_hints with debian/copyright_newhints
make: *** [debian/stamp-copyright-check] Error 1


Maybe it is due to something that changed in licensecheck recently?
I am using devscripts 2.13.3.

Note that on my system neither

licensecheck -c '.*' -r --copyright -i
'^debian/(changelog|copyright(|_hints|_newhints))' -l '99999' * |
/usr/lib/cdbs/licensecheck2dep5

nor

licensecheck -c '.*' -r --copyright -i
'^debian/(changelog|copyright(|_hints|_newhints))' -l '99999' *

produce the same result every time.

Bests,
	Giulio.