[Build-common-hackers] Bug#715504: Bug#715504: Please call dh_install before dh_systemd_*

[Jonas Smedegaard]

tags 715504 help moreinfo
thanks

Quoting Michael Stapelberg (2013-07-09 21:14:08)
> When trying to update the miredo package (which uses cdbs), I realized 
> that dh_systemd_enable, dh_installinit and dh_systemd_start are called 
> _before_ dh_install.
> 
> dh_install is used in this case to install miredo.service into the 
> files for the “miredo” package (as opposed to “miredo-server”).
> 
> dh_systemd_enable is called _before_ dh_install and therefore cannot 
> find any unit files.
> 
> Debhelper’s dh(1) does it in the right order: it first calls 
> dh_install, then dh_systemd_enable.
> 
> This affects all packages that ship a systemd service file upstream. 
> It does not affect the packages which ship a systemd service file in 
> debian/, which is why it was not found when testing :-).

Thanks for the bugreport.

I have honestly no clue about systemd, so need some more specific 
hand-holding here, please.

A patch would be quite welcome, but just very specific description on 
which exact calls need to be moved before/after which exact other calls 
is also useful.

It seems in fact that this  initial bugreport does that, in that it 
talks solely about dh_systemd_enable needing execution after dh_install.
But subject talks about dh_systemd_* and a follow-up also talks about 
other calls than dh_systemd_enable.

I need help here.

 - Jonas

-- 
 * Jonas Smedegaard - idealist & Internet-arkitekt
 * Tlf.: +45 40843136  Website: http://dr.jones.dk/

 [x] quote me freely  [ ] ask before reusing  [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 966 bytes
Desc: signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20140302/bc9bdeb3/attachment.sig>