[Build-common-hackers] Bug#712729: Bug#712729: The fix for this breaks other packages

Felipe Sateler fsateler at debian.org
Sat Oct 25 05:20:10 UTC 2014

Control: reopen -1
Control: severity -1 normal

On Sat, 11 Oct 2014 10:59:31 +0200 Jonas Smedegaard <dr at jones.dk> wrote:
> Quoting Felipe Sateler (2014-10-11 06:54:08)
> > On Tue, 9 Sep 2014 10:41:50 -0300 Felipe Sateler <fsateler at debian.org> wrote:
> >> On Tue, Sep 9, 2014 at 10:24 AM, Simon Ruderich <simon at ruderich.org> wrote:
> >>> On Mon, Sep 08, 2014 at 11:30:48PM -0300, Felipe Sateler wrote:
> >>>> Could you propose a patch filtering out the characters plus (+),
> >>>> minus (-) signs, and periods (.)?
> >>>
> >>> Sure, revised patch is attached.
> >>
> >> Great!
> >>
> >> Jonas, what do you think? Could you apply this patch please?
> >> Packages are getting built without the correct flags due to this bug,
> >> so an upload soon would be great.
> >>
> >
> > I have uploaded a NMU to delayed/0. This bug has gone too long
> > unfixed. Attached is the debdiff for the NMU.
> Thanks.  And sorry for the silence.

I didn't see this message until today by looking at the bug log, sorry
for not answering this. Next time please CC me.

> I am preparing a larger change which doesn't stall multiple seconds
> doing all those system calls, but evidently I was too slow preparing
> that, and I really appreciate your upload!

I see your new upload, but it doesn't seem to work:

% cat test
#!/usr/bin/make -f

include /usr/share/cdbs/1/class/makefile.mk

        echo CFLAGS=$(CFLAGS)
% make -f test all
echo CFLAGS=-g -O2 -fstack-protector-strong -Wformat
-Werror=format-security -Wall
CFLAGS=-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall

As you can see, "something" was not added to CFLAGS. Variations
with/without export or SET/APPEND/PREPEND don't seem to work either.

Your new implementation is way beyond my make-fu, though, and
debugging make is hard :(

Felipe Sateler

More information about the Build-common-hackers mailing list