[Build-common-hackers] Bug#712729: The fix for this breaks other packages
dr at jones.dk
Wed Sep 3 19:32:33 UTC 2014
Quoting Felipe Sateler (2014-09-03 20:47:58)
> Control: reopen -1
> Control: severity -1 serious
> On Thu, 21 Aug 2014 22:04:00 +0000 Jonas Smedegaard <dr at jones.dk> wrote:
>> * Fix preserve compiler flags set using DEB_* environment
>> variables, in langcore.mk.
>> Closes: bug#712729. Thanks to Simon Ruderich, Emilio Pozuelo
>> Monfort and Markus.
> This change introduces a bug: packages with names that are illegal
> shell variable names. For an example, see pulseaudio. This change
> results in build flags not being applied.
> The filter needs to be smarter.Perhaps only exporting the variables
> that look like the ones in the buildflags manpage should be exported:
> allvars = $(filter DEB_%,$(.VARIABLES))
> filt = $(foreach suf,APPEND PREPEND SET STRIP OPTIONS,$(filter
> exp = $(foreach flag,$(filt),$(flag)="$($(flag))")
> Please fix this asap, as this change is breaking other packages.
>  https://buildd.debian.org/status/fetch.php?pkg=pulseaudio&arch=kfreebsd-i386&ver=5.0-11&stamp=1409110310
Could you please elaborate on this - e.g. on the concrete example.
Sorry, I looked at that build log but failed to extract what failed and
how it relates to the change in CDBS - I do *not* suspect that your
findings are wrong, merely that I need it spelled out with bigger
* Jonas Smedegaard - idealist & Internet-arkitekt
* Tlf.: +45 40843136 Website: http://dr.jones.dk/
[x] quote me freely [ ] ask before reusing [ ] keep private
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 949 bytes
More information about the Build-common-hackers