[Build-common-hackers] Bug#712729: The fix for this breaks other packages

Simon Ruderich simon at ruderich.org
Wed Sep 3 22:03:21 UTC 2014

On Wed, Sep 03, 2014 at 03:37:01PM -0400, Felipe Sateler wrote:
> The change proposed by Simon prepends every variable known to make
> that starts with DEB_ , along with its value, to the invocation of
> dpkg-buildflags. The problem is that some make variable names are
> illegal as shell variable names. Like for example
> DEB_DBG_PACKAGE_pulseaudio-module-zeroconf, which is not a valid shell
> variable name. So the invocation expands to something like:

Hello Felipe,

The attached patch should fix this issue. I haven't used a
whitelist of variables (which might get out of date) but instead
filtered out all variables containing "-" in their names.

I'm not sure how to create a Makefile variable with a "-" in it,
I failed to do so, but the patch should work. Please test it, as
I haven't tried to build pulseaudio with the patch.

+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: cdbs-buildflags.patch
Type: text/x-diff
Size: 971 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20140904/16785749/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20140904/16785749/attachment.sig>

More information about the Build-common-hackers mailing list