[Build-common-hackers] Bug#712729: The fix for this breaks other packages

Simon Ruderich simon at ruderich.org
Mon Sep 8 22:51:16 UTC 2014


On Wed, Sep 03, 2014 at 06:17:52PM -0400, Felipe Sateler wrote:
> The problem is that such a blacklist could include other invalid shell
> characters: + comes to mind, but I don't know the entire set of
> character which are allowed as shell variables, as opposed to the
> valid make allowed chars.

Hello Felipe,

True, but I think those characters won't occur very often and I
wanted to provide a general fix which won't brake in the future
when new options are added.

> Maybe a more appropriate way would be to, instead of filtering out the
> -, filter by matching FLAGS (after the DEB_ prefix)?

Not all options contain FLAGS in their name, e.g.
DEB_BUILD_MAINT_OPTIONS.

> You can do so like this:

Thank you.

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20140909/02627602/attachment.sig>


More information about the Build-common-hackers mailing list