[Build-common-hackers] Bug#781076: cdbs: perlmodule-vars.mk LDDLFLAGS quoting problem

[Niko Tyni]

Package: cdbs
Version: 0.4.129
Severity: serious
Control: affects -1 libhtml-wikiconverter-wikkawiki-perl
X-Debbugs-Cc: libhtml-wikiconverter-wikkawiki-perl at packages.debian.org

libhtml-wikiconverter-wikkawiki-perl is failing to build on current sid with

  /usr/bin/make  -C . OPTIMIZE="-g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wall -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -Werror=date-time -D_FORTIFY_SOURCE=2 -D_REENTRANT -D_GNU_SOURCE -DDEBIAN -fwrapv -fno-strict-aliasing -pipe -I/usr/local/include" LDDLFLAGS="-Wl,-z,relro" -shared -L/usr/local/lib -fstack-protector  all
  /usr/bin/make: invalid option -- 'a'
  /usr/bin/make: invalid option -- '/'
  /usr/bin/make: invalid option -- 'u'
  /usr/bin/make: invalid option -- '/'
  Usage: make [options] [target] ...
  Options:
  [...]

It looks like the LDDFLAGS quoting in
/usr/share/cdbs/1/class/perlmodule-vars.mk should include
$(cdbs_perl_lddlflags) as currently -shared and -L/usr/local/lib are
passed to make, not ld.

There's a build log at
 https://reproducible.debian.net/rb-pkg/testing/amd64/libhtml-wikiconverter-wikkawiki-perl.html

and I've verified that the same thing happens on a normal toolchain too.

It's a bit strange that all the arch-specific stuff is passed to an arch-indep
build, but I guess that shouldn't matter much.

Note that even with a fixed cdbs, libhtml-wikiconverter-wikkawiki-perl
is failing one seemingly unrelated test (wikkawiki.t), but the 
test results are ignored so the build still succeeds.
-- 
Niko Tyni   ntyni at debian.org