[Build-common-hackers] Bug#811555: dh_systemd_enable should run before dh_installinit

Dan Nicholson nicholson at endlessm.com
Tue Jan 19 20:00:52 UTC 2016


Package: cdbs
Version: 0.4.130

Currently, the debhelper rules run dh_systemd_enable and
dh_systemd_start consecutively towards the end of the binary-install
phase. However, according to dh_systemd_enable(1), dh_systemd_enable
should run before dh_installinit. Indeed, the dh-systemd debhelper
sequence module does it this way:

$ cat /usr/share/perl5/Debian/Debhelper/Sequence/systemd.pm 
#!/usr/bin/perl
use warnings;
use strict;
use Debian::Debhelper::Dh_Lib;

# dh_systemd_enable runs unconditionally, and before dh_installinit, so that
# the latter can use invoke-rc.d and all symlinks are already in place.
insert_before("dh_installinit", "dh_systemd_enable");

# dh_systemd_start handles the case where there is no corresponding init
# script, so it runs after dh_installinit.
insert_after("dh_installinit", "dh_systemd_start");

1

The attached patch should fix it.

--
Dan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Run-dh_systemd_enable-before-dh_installinit.patch
Type: text/x-patch
Size: 1702 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/build-common-hackers/attachments/20160119/ecac4c87/attachment.bin>


More information about the Build-common-hackers mailing list