[Build-common-hackers] Bug#824689: cdbs: syntax error in perl-makemaker.mk

[Niko Tyni]

Package: cdbs
Version: 0.4.133
Severity: serious
User: reproducible-builds at lists.alioth.debian.org
Usertags: ftbfs
X-Debbugs-Cc: reproducible-builds at lists.alioth.debian.org, pkg-perl-maintainers at lists.alioth.debian.org

Many packages are failing to build on current sid with these symptoms:

  /bin/sh: 1: Syntax error: ")" unexpected
  /usr/share/cdbs/1/class/perl-makemaker.mk:47: recipe for target 'Makefile' failed
  make: *** [Makefile] Error 2
  dpkg-buildpackage: error: debian/rules build gave error exit status 2

This seems to be a regression in cdbs 0.4.133, commit
https://anonscm.debian.org/cgit/collab-maint/cdbs.git/commit/?id=c0098c1979699fdb8099183ccf48455c009a71ac

-       $(error DEB_BUILDDIR and DEB_SRCDIR must be the same for Perl builds))
+       $(error DEB_BUILDDIR and DEB_SRCDIR must be the same \
+               for Perl builds)))

Note the added closing parenthesis.

Example failures include

 https://tests.reproducible-builds.org/rb-pkg/unstable/amd64/libweb-machine-perl.html
 https://tests.reproducible-builds.org/rb-pkg/unstable/i386/libmoox-aliases-perl.html
 https://tests.reproducible-builds.org/rb-pkg/unstable/i386/libmodule-install-trustmetayml-perl.html

-- 
Niko Tyni   ntyni at debian.org