[Buildd-tools-devel] Removing strict distribution check

Francesco Paolo Lovergine frankie@debian.org
Mon, 6 Dec 2004 18:57:40 +0100


On Mon, Dec 06, 2004 at 06:44:08PM +0100, Michael Banck wrote:
> Hi,
> 
> if somebody (just as a theoretical example ;) wants to built Ubuntu
> packages on a Debian system via sbuild, they would have to get a warty
> or hoary chroot and then do something like 'sbuild -d warty foo.dsc'.
> 
> However, sbuild spews out a 'Bad distribution' header because neither
> warty nor hoary are known to them. Ubuntu does not use generic names
> like 'stable', 'testing', 'unstable' and thus it would be cumbersome to
> hardcode their codenames into sbuild. I therefore propose the following
> change:
> 
> --- sbuild.orig 2004-12-06 18:39:41.000000000 +0100
> +++ sbuild      2004-12-06 18:39:52.000000000 +0100
> @@ -135,8 +135,6 @@
>                 $main::distribution = "stable"   if $main::distribution eq "s";
>                 $main::distribution = "testing"  if $main::distribution eq "t";
>                 $main::distribution = "unstable" if $main::distribution eq "u";
> -               die "Bad distribution\n"
> -                       if !isin($main::distribution, keys(%main::dist_order));
>         }
>         elsif (/^-p/ || /^--purge/) {
>                 if (/^-p(.)/ || /^--purge=(.)/) {
> 
> 
> OK to commit? Also note that you will have similar trouble when trying
> to sbuild for experimental (if you care to setup an experimental
> chroot), AFAIK.
> 

It seems ok for me.

-- 
Francesco P. Lovergine