[Buildd-tools-devel] Bug#381271: schroot: After using --begin-session, reading session configuration fails

[Roger Leigh]

Package: schroot
Version: 1.0.0-1
Severity: important
Tags: patch

After running with --begin-session:

$ schroot -l --all
E:i /var/lib/schroot/session/sid-snap-ed005c62-f3ae-4fab-b062-af5dca884fb3:
line 8 [sid-snap-ed005c62-f3ae-4fab-b062-af5dca884fb3] location: :
Location must have an absolute path

The validation logic is being too strict when re-reading the session
configuration.  Strict validation is already handled in derived chroot
types.

Index: sbuild/sbuild-chroot.cc
===================================================================
--- sbuild/sbuild-chroot.cc	(revision 969)
+++ sbuild/sbuild-chroot.cc	(working copy)
@@ -187,7 +187,7 @@
 void
 sbuild::chroot::set_location (std::string const& location)
 {
-  if (!is_absname(location))
+  if (!location.empty() && !is_absname(location))
     throw error(location, LOCATION_ABS);
 
   this->location = location;


Regards,
Roger

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (990, 'unstable')
Architecture: powerpc (ppc)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-1-powerpc
Locale: LANG=en_GB.UTF8, LC_CTYPE=en_GB.UTF8 (charmap=UTF-8)

Versions of packages schroot depends on:
ii  libboost-program-options1.33. 1.33.1-5   program options library for C++
ii  libboost-regex1.33.1          1.33.1-5   regular expression library for C++
ii  libc6                         2.3.6-17   GNU C Library: Shared libraries
ii  libgcc1                       1:4.1.1-10 GCC support library
ii  liblockdev1                   1.0.3-1    Run-time shared library for lockin
ii  libpam0g                      0.79-3.1   Pluggable Authentication Modules l
ii  libstdc++6                    4.1.1-10   The GNU Standard C++ Library v3
ii  libuuid1                      1.39-1     universally unique id library

schroot recommends no packages.

-- no debconf information