Bug#369718: [Buildd-tools-devel] Bug#369718: ugly error when $log_dir doesn't exist

[Roger Leigh]

Martin Michlmayr <tbm at cyrius.com> writes:

> 22701:tbm at deprecation: ~/debian/build] /usr/share/sbuild/checkchroot
> /home/tbm/debian/build/logs is not a directory
> Compilation failed in require at /usr/share/sbuild/checkchroot line 24.
> BEGIN failed--compilation aborted at /usr/share/sbuild/checkchroot line 24.
> zsh: exit 2     /usr/share/sbuild/checkchroot

This is Sbuild/Conf.pm, lines 118-119:

	die "$Sbuild::Conf::log_dir is not a directory\n"
		if ! -d $Sbuild::Conf::log_dir;

How would you prefer we handle this sanity check?

We could, for example, move it to after module initialisation.
However, there are a number of similar checks, and not all can be
safely moved out of the init stage (they are required to work as soon
as they are required by other modules).

We could also create the directory if not existing, and error out only
a non-directory already exists.


Regards,
Roger

-- 
Roger Leigh
                Printing on GNU/Linux?  http://gutenprint.sourceforge.net/
                Debian GNU/Linux        http://www.debian.org/
                GPG Public Key: 0x25BFB848.  Please sign and encrypt your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20060610/b020c674/attachment.pgp