[Buildd-tools-devel] Things to do for schroot 1.0

Roger Leigh rleigh at whinlatter.ukfsn.org
Mon Jun 26 14:09:10 UTC 2006


These are things I'd like to complete for 1.0.  They are roughly in
order of increasing difficulty.

If anyone wants to tackle any of these items, feel free!


Regards,
Roger


* Update documentation schroot.conf examples.

  Currently, they don't include newer options or program outout in
  examples is outdated.

* Fix compiler warnings.

  Some of the templated code gives uninitialised variable warnings.
  They are harmless, but it would be nice to eliminate.

* sbuild-session unnnamed namespace helper routines shouldn't exit

  They should throw an exception instead.  Need to check suitable
  catch blocks are in place.

* Review quoting style.

  Use of single and double quotes in strings is inconsistent.  Needs
  the boost::format markup changes fixing first.  What are other
  projects doing?

* Handle charset conversion errors more gracefully.

  sbuild-util widen_string and narrow_string.  Currently an error
  occurs if in a C locale the string contains non-US-ASCII characters
  or, in other locales if the gettext message catalogue has bad
  strings.  The string is truncated to the point of error, or may be
  empty depending where the error is.  We should error out a bit
  better in this case.  Assertion, or exception?

* Use boost::format markup in the standard error strings.

  This will complete the i18n support for error translation.  It will
  also allow templated exceptions which will simplify error reporting
  for non-string types.  I removed the markup when converting the code
  to use a standard templated exception class (sbuild_custom_error).

* Suggest running with --help for helper binaries.

  When options are incorrect, suggest running --help as for schroot,
  dchroot and dchroot-dsa.  This depends on implementing frontend code
  in helper binaries.

* Frontend code for helper binaries.

  schroot-releaselock and schroot-listmounts should use a frontend
  (main class) like schroot, dchroot and dchroot-dsa.

* Replace run-parts(8) usage with internal reimplementation.

  We don't need many of the run-parts features, and this is the only
  Debian-specific feature

* Move PAM open_session and close_session logic.

  Move back from session to auth, or don't open the session in the
  child process (because the open/close happen in different
  processes).

* Docstring argument namespace usage.

  Doxygen is currently failing to parse correct C++ due to what looks
  like namespace bugs in doxygen.  It would be great if we could fix
  the code by fully qualifying the namespace where appropriate.

* Chroot config errors should report the keyfile line number.

  This is difficult, because the keyfile parsing is completed, and the
  line numbers are lost.  Perhaps the keyfile should cache the line
  numbers during read and recompute on write?


-- 
Roger Leigh
                Printing on GNU/Linux?  http://gutenprint.sourceforge.net/
                Debian GNU/Linux        http://www.debian.org/
                GPG Public Key: 0x25BFB848.  Please sign and encrypt your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20060626/318fbdc2/attachment.pgp


More information about the Buildd-tools-devel mailing list