[Buildd-tools-devel] [patch] sbuild process group trouble

[Roger Leigh]

Roger Leigh <rleigh at whinlatter.ukfsn.org> writes:

> In a number of places, when sbuild forks/execs a child process, it
> calls setpgrp() in the child, between the fork and exec, in order to
> ensure the child runs in a separate process group.
>
> The attached patch is a proposed fix for this, which removes all of
> the setpgrp calls.  This appears to work just fine, but I'm reluctant
> to apply it without a full understanding of what the original use of
> setpgrp was intended to achieve.

I've applied this patch, because it does break builds without it.  It
also is likely the reasons for unexplained hangs in the past: if any
process attempted to read/write to stdin, they would be stopped due to
not being in the foreground process group.  This hasn't been a problem
for buildds, because buildd has no controlling tty, and it's almost
certainly incorrect.

If this does cause unexpected problems, it's simple to revert.


Regards,
Roger

-- 
Roger Leigh
                Printing on GNU/Linux?  http://gutenprint.sourceforge.net/
                Debian GNU/Linux        http://www.debian.org/
                GPG Public Key: 0x25BFB848.  Please sign and encrypt your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20060308/787b0fb7/attachment.pgp