Bug#368066: [Buildd-tools-devel] Bug#368066: sbuild: version strings should be allowed to be "0"

[Roger Leigh]

Santiago Vila <sanvila at unex.es> writes:

> Package: sbuild
> Version: 0.45
> Severity: minor
> Tags: patch
>
> The string "0" is valid as a string version for a Debian package.
> Therefore, sbuild should not complain about it.
>
> [ This was already reported as Bug #300205. Sorry for reporting it again
>   but it seems the fix was not applied, or it was lost, or who knows ].

That's my fault, I think.

> -		if (!$version) {
> +		if ($version eq "") {

$version may not always be defined, so it should probably be

if (!defined $version || $version eq "")

Would that be OK?


Regards,
Roger

-- 
Roger Leigh
                Printing on GNU/Linux?  http://gutenprint.sourceforge.net/
                Debian GNU/Linux        http://www.debian.org/
                GPG Public Key: 0x25BFB848.  Please sign and encrypt your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20060519/f172fee4/attachment.pgp