[Buildd-tools-devel] [PATCH] scratchbox support in sbuild

[Roger Leigh]

Guillem Jover <guillem.jover at nokia.com> writes:

> Long time ago (last year or so), I told Roger I'd be adding sbox
> support for sbuild, and I did but after some time stopped using it and
> dropped the ball, and didn't have time to add support to wanna-build
> as well.
>
> The patches are against an old version of sbuild, at the time I got it
> working, but cannot remember anymore if I had to hack something else
> in sbuild or in sbox itself, although most of the needed patches in
> the latter got merged. Also now that sbox2 is being uploaded to Debian
> by Riku Voipio would make sense to get the patch forward ported.

It's worth mentioning that sbuild has changed quite a bit since you
made the patch; it will not apply to the current version for this
reason.  Some variables such as chroot_mode have been removed, but if
sbox support was merged, it should be added back in.

The current sbuild is at
  svn://svn.debian.org/svn/buildd-tools/trunk/sbuild

> I might have time to get to this in the future, but no guarantees,
> others are welcome to finish this, of course. ;)

I don't think I'll have much time to do this in the near future, but
once sbox2 is available in Debian I might be able to give it a try.

I will however be very happy to review and comment on any suggested
patches, as well as merge them.  The existing patch looks very good;
it shouldn't take much work to port to the current version, and should
in some parts actually be simpler.  Some points:

- chroot_mode would need adding back in.
- only Sbuild/Chroot.pm should need changing; as you have mostly done
  in the patch
- I don't understand why the main::arch check needs altering in
  Sbuild/Log.pm.in and sbuild.  Note that the arch check has been
  altered in the meantime to check the arch /inside/ the build chroot,
  to allow building e.g. i386 binaries in chroots on amd64 systems.
- fakeroot should not be run directly; it's $conf::fakeroot.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20070415/8d1c289f/attachment.pgp