[Buildd-tools-devel] Bug#391319: Bug#391319: ping

[Roger Leigh]

Kees Cook <kees at outflux.net> writes:

> Hello!  Any progress on incorporating this patch?  I find it very
> handy to have this patch installed so I can forcefully shutdown an
> schroot.

I hope to get it in the next release.  I've been using it for a few
months, and now that etch is released it can go in.

The one problem I would like to get fixed first, however, is the delay
while killing processes, if there are no processes to kill.  This
makes the typical case of running schroot or ending a session wait for
a good few seconds.  I would like it to be ~instantaneous in the case
no processes need killing.

I think the while loop needs some optimisation, such as checking if
the process has terminated so that it can break out of the loop early.
I think simply repeating the readlink inside the loop would be
sufficient.  So instead of "while kill", so "while readlink", and then
kill inside the loop.

Another nice addition would be to print out which processes are being
killed if in verbose mode.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20070523/11362a72/attachment.pgp