[Buildd-tools-devel] Bug#391319: Bug#391319: Bug#391319: schroot: leftover processes cause umount to fail

[Roger Leigh]

Kees Cook <kees at outflux.net> writes:

> The only thing I can see to change is just a very minor performance tweak,
> which is to move the exe readlink into the verbose if, just to save one
> exec unless we're in verbose:
>
> #... was here ...
> +        root=$(readlink /proc/"$pid"/root || true)
> +        if [ "$root" = "$1" ]; then
> +            if [ "$AUTH_VERBOSITY" = "verbose" ]; then
> +                exe=$(readlink /proc/"$pid"/exe || true)         #<- now here
> +                echo "Killing left-over pid $pid (${exe##$1})"

Done!

Many thanks for all your work here.  This will be really useful, and a
lot of people have wanted something like this.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20070528/33048e77/attachment.pgp