[Buildd-tools-devel] Bug#426416: Bug#426416: schroot: Cannot umount "" on old chroots

[Roger Leigh]

tags fixed-upstream pending
thanks

Federico Di Gregorio <fog at debian.org> writes:

> Some days ago schroot begun to report the following error
>
> E: sid32-61f1f291-86fe-40b1-b328-0de469e9ff98: Chroot setup failed:
> stage=setup-stop
>  sid32-61f1f291-86fe-40b1-b328-0de469e9ff98Cannot umount ""
>
> when ending old sessions after a reboot done with open sessions. The following
> one-line patch fixes the problem by not trying to umount sessions that don't
> have anything mounted.

Thanks for the patch.  I fixed this in SVN a couple of days back, and
I'm hoping to get it uploaded tonight if possible.

> --- 10mount     2007-05-28 18:16:50.000000000 +0200
> +++ 10mount.new 2007-05-28 18:16:34.000000000 +0200
> @@ -28,6 +28,7 @@
>  do_umount_all()
>  {
>      mounts="$("$LIBEXEC_DIR/schroot-listmounts" -m "$1")"
> +    test -n "$mounts" || exit 0
>      echo "$mounts" |
>      while read mountloc; do
>         if [ "$AUTH_VERBOSITY" = "verbose" ]; then

I just did
do_umount_all()
{
    mounts="$("$LIBEXEC_DIR/schroot-listmounts" -m "$1")"
+    if [ "x$mounts" != 'x' ]; then
        echo "$mounts" |
        while read mountloc; do
            if [ "$AUTH_VERBOSITY" = "verbose" ]; then
                echo "Unmounting $mountloc"
            fi
            umount "$mountloc" || exit 1
        done || exit 1
+    fi
}


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20070528/14f5dd6a/attachment.pgp