[Buildd-tools-devel] Bug#493325: Option --make-binNMU handling broke in 0.57.4

[Greg Hudson]

Package: sbuild
Version: 0.57.4-1
Severity: important
Tags: patch

If you supply the --make-binNMU option to sbuild, you get an error:

Can't modify non-lvalue subroutine call at /usr/share/perl5/Sbuild/Options.pm line 132.

This is because of a buggy conversion of the relevant code to a new
style of storing and retrieving arguments.  A patch to fix this:

--- Options.pm.orig	2008-08-02 00:36:51.000000000 -0400
+++ Options.pm	2008-08-02 00:37:39.000000000 -0400
@@ -130,7 +130,7 @@
 		       "make-binNMU=s" => sub {
 			   $self->set('binNMU', $_[1]);
 			   $self->set('binNMU Version',
-				      $self->get('binNMU Version') ||= 1);
+				      $self->get('binNMU Version') || 1);
 		       },
 		       "binNMU=i" => sub {
 			   $self->set('binNMU Version', $_[1]);

-- System Information:
Debian Release: lenny/sid
  APT prefers testing
  APT policy: (500, 'testing'), (400, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-1-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages sbuild depends on:
ii  adduser                3.108             add and remove users and groups
ii  apt                    0.7.14+b1         Advanced front-end for dpkg
ii  dctrl-tools            2.13.0            Command-line tools to process Debi
ii  debathena-msmtp-mta [m 1.3~debian4.1~0.1 msmtp sendmail wrapper for Debian-
ii  devscripts             2.10.34           scripts to make the life of a Debi
ii  dpkg-dev               1.14.20           Debian package development tools
ii  perl                   5.10.0-11.1       Larry Wall's Practical Extraction 
ii  perl-modules           5.10.0-11.1       Core Perl modules
ii  schroot                1.2.1-1           Execute commands in a chroot envir

Versions of packages sbuild recommends:
ii  debootstrap                   1.0.10     Bootstrap a basic Debian system
ii  fakeroot                      1.9.5      Gives a fake root environment

Versions of packages sbuild suggests:
pn  deborphan                     <none>     (no description available)
ii  wget                          1.11.4-1   retrieves files from the web

-- no debconf information