[Buildd-tools-devel] Bug#483338: sbuild: ~*=PROVIDED=*= hack breaks build-conflicts

[Lucas Nussbaum]

tags 483338 + patch
thanks

On 28/05/08 at 14:43 +0200, Lucas Nussbaum wrote:
> Package: sbuild
> Version: 0.57.3-1
> 
> Hi,
> 
> With the sbuild version from git master, versioned build-conflicts on
> provided packages cause builds to abort.
> 
> This should probably be special-cased.
> 
> Example packages:
> came:
> dpkg - warning: ignoring request to remove linux-kernel-headers which isn't installed.
> Checking correctness of source dependencies...
> After installing, the following source dependencies are still unsatisfied:
> linux-kernel-headers(inst ~*=PROVIDED=*= << conflicted 2.5.999-test7-bk-10)
> Source-dependencies not satisfied; skipping came
> 
> dovecot:
> dpkg - warning: ignoring request to remove linux-kernel-headers which isn't installed.
> Checking correctness of source dependencies...
> After installing, the following source dependencies are still unsatisfied:
> linux-kernel-headers(inst ~*=PROVIDED=*= <= conflicted 2.5.999-test7-bk-17)
> Source-dependencies not satisfied; skipping dovecot
> 
> mysql-gui-tools:
> Checking correctness of source dependencies...
> After installing, the following source dependencies are still unsatisfied:
> libmysqlclient-dev(inst ~*=PROVIDED=*= << conflicted 4.1)
> Source-dependencies not satisfied; skipping mysql-gui-tools
> 
> t38modem:
> dpkg - warning: ignoring request to remove linux-kernel-headers which
> isn't installed.
> Checking correctness of source dependencies...
> After installing, the following source dependencies are still
> unsatisfied:
> linux-kernel-headers(inst ~*=PROVIDED=*= << conflicted
> 2.5.999-test7-bk-14)
> Source-dependencies not satisfied; skipping t38modem
> 
> transfig:
> Checking correctness of source dependencies...
> After installing, the following source dependencies are still
> unsatisfied:
> gs-esp(inst ~*=PROVIDED=*= << conflicted 8.50)
> Source-dependencies not satisfied; skipping transfig

Hi,

Here is a patch for this issue:

diff --git a/lib/Sbuild/Build.pm b/lib/Sbuild/Build.pm
index 792d4c4..64127bf 100644
--- a/lib/Sbuild/Build.pm
+++ b/lib/Sbuild/Build.pm
@@ -1310,6 +1310,10 @@ sub check_dependencies (\$\@) {
                if (!$dep->{'Rel'}) {
                    $fail .= "$name(still installed) ";
                }
+               elsif ($stat->{'Version'} == '~*=PROVIDED=*=') {
+                   # It's a versioned build-conflict, but we installed
+                   # a package that provides the conflicted package. It's ok.
+               }
                elsif (version_compare($stat->{'Version'}, $dep->{'Rel'},
                                       $dep->{'Version'})) {
                    $fail .= "$name(inst $stat->{'Version'} $dep->{'Rel'} ".
-- 
| Lucas Nussbaum
| lucas at lucas-nussbaum.net   http://www.lucas-nussbaum.net/ |
| jabber: lucas at nussbaum.fr             GPG: 1024D/023B3F4F |