[Buildd-tools-devel] Bug#462680: Bug#462680: schroot: COPYFILES option does not work

[Roger Leigh]

On Sat, Jan 26, 2008 at 09:17:32PM +0100, Jan De Luyck wrote:
> I recently tried to make schroot copy the files I wanted using the 
> COPYFILES directive. This does not work.
> 
> schroot.conf entry:
> 
> [sid-ia32]
> description=Debian sid (unstable)
> location=/var/chroot/sid-ia32
> priority=3
> users=potato,devilkin,root
> groups=potato,devilkin,root
> root-groups=root
> aliases=unstable,default
> personality=linux32
> type=plain
> run-exec-scripts=true
> run-setup-scripts=true
> script-config=/etc/schroot.d/script-defaults
                     ^^^^^^^^^ there's no .d neededed here.

		     Note this is already relative to /etc/schroot, so
		     this will try to load
		     /etc/schroot/etc/schroot.d/script-defaults, which
		     probably doesn't exist.  See schroot.conf(5).

> I needed to add the script-config file, otherwise it wouldn't do 
> anything even though the man page says that script-defaults is the
> default.

I double checked this, and it is the default.

Run "schroot -v" and you'll see a CHROOT_SCRIPT_CONFIG line which tells
you the name of the file.  I guess in your case it might not be
sourcing the file, because it won't include it if it doesn't exist
--we might want to stop with an error in this case.

> /etc/schroot/setup.d/20copyfiles: line 73: : No such file or directory
                                            ^
					    No file, so COPYFILES not
					    set.

So, to summarise what I think is going on (though I'd appreciate you
check what I suggested above):

- your configuration is incorrect; probably the absolute path.
- if script-config is missing, we are silently not including it, but
  we should probably either error out with a suitable error, or fall
  back to reasonable defaults.
- if copyfiles is not defined, 20copyfiles is giving an error.  We need
  to add some additional checks here to make sure that doesn't happen.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.