[Buildd-tools-devel] Bug#488726: schroot: Doesn't pass mount options when mounting lvm snapshots

[Timothy G Abbott]

Package: schroot
Version: 1.2.0-1
Severity: wishlist

I have an LVM volume which has an actual partition table in it (so that a 
snapshot of it can be booted as a Xen VM), and which I want to also be 
able to access snapshots of via schroot.  Because it has a partition 
table, I mount it with the option offset=32256B, and specify in the 
schroot configuration

mount-options=offset=32256B

Now, this works well for accessing the source chroot, but for accessing a 
snapshot of the volume, schroot fails to pass the offset option to mount, 
and fails to successfully mount the chroot.

I've traced this down to the following code in 
/etc/schroot/setup.d/10mount:

     elif [ "$CHROOT_TYPE" = "lvm-snapshot" ]; then
         CHROOT_MOUNT_OPTIONS=""
         CHROOT_MOUNT_DEVICE="$CHROOT_LVM_SNAPSHOT_DEVICE"
     fi

Now, assuming there's a good reason why the mount options for 
lvm-snapshots are cleared (perhaps someone wants different mount options 
for accessing the source and the snapshots?), it would be good to have an 
option to specify the snapshot's mount options.

If there isn't, I guess the CHROOT_MOUNT_OPTIONS="" line should be deleted 
(that's what I've done for now).

 	-Tim Abbott