[Buildd-tools-devel] Bug#469038: Bug#469038: new mount helper does not mkdir

[Roger Leigh]

Kees Cook <kees at outflux.net> writes:

> Package: schroot
> Version: 1.1.6-1
> Severity: normal
> Tags: patch
>
> First, the new mount helper is great.  I've finally had a chance to play
> with it.  However, I noticed that unlike the original 10mount "do_mount"
> function, it does not create target mount point directories, which
> results in:
>
> I: Executing '/bin/mount -v -t none -o rw,bind /scratch /var/lib/schroot/mount/edgy-4bbec1fc-044d-4ec0-9613-c783e4c04f5f/scratch'
> mount: mount point /var/lib/schroot/mount/edgy-4bbec1fc-044d-4ec0-9613-c783e4c04f5f/scratch does not exist
>
> (This used to work when I used a modified 10mount that just made extra
> calls to do_mount.)
>
> I've attempted a boosty solution, which is attached (though it requires
> that libboost-filesystem-dev be added to the Build-Depends).  Note this is my
> first use of boost -- pardon any ugliness.  ;)

Thanks, it looks great at first glance.  I haven't used
boost::filesystem yet myself; I just use mkdir(2), but that's not a
problem so long as it works!

I'm just about to set of to the US for a week, but I will review it
and apply it once I get back.


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20080302/d28efdce/attachment.pgp