[Buildd-tools-devel] Bug#403246: Bug#403246: should this bug be reassigned to the policy?

[Roger Leigh]

Robert Millan <rmh at aybabtu.com> writes:

> On Fri, Mar 21, 2008 at 11:06:08PM +0100, Piotr Ożarowski wrote:
> Policy makes it clear that this syntax is allowed, other utilities (e.g.
> dpkg-checkbuilddeps) comply with Policy but sbuild doesn't.  It sounds
> clearly like a bug in sbuild to me.
>
>> If you think this bug should be fixed anyway (I don't see "wontfix" tag),
>> please tell me, I will learn perl and fix it for you.
>
> I'd appreciate if you did.  I've been wanting to fix this for a long time,
> but never got around to it (I don't know perl either).

Patches are always welcome.  Even if you aren't familiar with Perl, I
can help review any changes you want to make.  It might be that if you
can describe what aspect of the current behaviour is wrong I can try
to implement the change for you.

In this case, however, there is a need to retain compatibility with
the version used on the autobuilders, despite it also being broken.
This would mean it won't break Lucas' autobuilder and people can still
rely on the old behaviour (needed to test if packages autobuild
correctly on the Debian autobuilders).  I would suggest simply adding
a new config option such as

  $broken_dependencies=0

to disable that, and make your changes conditional in the code:

  if ($conf::broken_dependencies) {
     [old behaviour]
  } else {
     [correct behaviour]
  }

At such time this version is used on all buildds, and it definitely
complies with Policy, we can switch it to be the default and remove
the old broken code.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 188 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20080526/711636fa/attachment.pgp