[buildd-tools-devel] Bug#523670: Bug#523670: sbuild: --help and --version options don't work if not in group sbuild

[Roger Leigh]

On Sat, Apr 11, 2009 at 03:02:02PM -0400, Tim Abbott wrote:
> package: sbuild
> version: 0.57-7.1
> severity: minor
> 
> If you haven't configured sbuild on a machine, and you try to look at the 
> built-in help documentation, you get an error:
> 
> $ sbuild --help
> User tabbott is not a member of group sbuild
> See "User Setup" in sbuild-setup(7)
> 
> Probably options like --help, --version, etc. should work even if you're 
> not in group sbuild.

Definitely.  We currently do options parsing after loading the configuration
(since the options modify the configuration).  However, this is also the
point at which we do that check.

I'll merge the two together so that the options to parse are passed into
the configuration file contructor (optional) so that it can check the
options before doing the check.  Alternatively, I could just remove the
check, since the real access control is provided by sudo/schroot, or
turn the error into a warning.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.