[buildd-tools-devel] Testing of schroot 1.3 unionfs support

Tim Abbott tabbott at ksplice.com
Sat Aug 1 18:29:13 UTC 2009


Okay, I grabbed the latest schroot master (tagged 1.3-rc1) and tried it 
out.  It works successfully for unionfs chroots using aufs.

It did not work for my LVM snapshot chroots due to a quoting bug (patch 
fixing this below).  

However, it immediately segfaults for block-device chroots (in my case, 
source chroots for LVM snapshot chroots).  I'll debug a bit later today.

	-Tim Abbott

Properly quote do_mount calls in 10mount.

Signed-off-by: Tim Abbott <tabbott at ksplice.com>
---
 etc/setup.d/10mount |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/etc/setup.d/10mount b/etc/setup.d/10mount
index a8e8b5c..b0041d9 100755
--- a/etc/setup.d/10mount
+++ b/etc/setup.d/10mount
@@ -149,9 +149,9 @@ if [ "$CHROOT_TYPE" = "directory" ] || [ "$CHROOT_TYPE" = "file" ] || [ "$CHROOT
 	fi
 
 	if [ "$CREATE_UNION" = "yes" ]; then
-	    do_mount $CHROOT_MOUNT_OPTIONS "$CHROOT_MOUNT_DEVICE" "$CHROOT_UNION_UNDERLAY_DIRECTORY"
+	    do_mount "$CHROOT_MOUNT_OPTIONS" "$CHROOT_MOUNT_DEVICE" "$CHROOT_UNION_UNDERLAY_DIRECTORY"
 	else
-	    do_mount $CHROOT_MOUNT_OPTIONS "$CHROOT_MOUNT_DEVICE" "$CHROOT_MOUNT_LOCATION"
+	    do_mount "$CHROOT_MOUNT_OPTIONS" "$CHROOT_MOUNT_DEVICE" "$CHROOT_MOUNT_LOCATION"
 	fi
 
 	if [ "$CREATE_UNION" = "yes" ]; then
-- 
1.6.3.3




More information about the Buildd-tools-devel mailing list