[buildd-tools-devel] [PATCH 08/11] [run-parts, chroot-config] Skip hidden files

Roger Leigh rleigh at codelibre.net
Thu Aug 13 20:00:26 UTC 2009


On Mon, Aug 10, 2009 at 08:12:17PM +0200, Jan-Marek Glogowski wrote:
> run-parts(8) skips hidden files so don't use hidden configs
> or run run-parts skripts.

The is_valid_filename() call immediately after your changes uses
a regular expression match to ensure it won't look at incorrectly-
named files, which includes hidden files.

Unless is_valid_filename isn't functioning correctly, I would rather
not apply this patch, since it should be redundant.  It also allows
the filename validation logic to be changed in a single place.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20090813/4cce486c/attachment.pgp>


More information about the Buildd-tools-devel mailing list