[buildd-tools-devel] Bug#551311: Bug#551311: Updated patches for debuild like functionality in sbuild.

[Andres Mejia]

On Saturday 12 December 2009 05:52:12 Roger Leigh wrote:
> On Sat, Dec 12, 2009 at 12:42:10AM -0500, Andres Mejia wrote:
> > On Friday 11 December 2009 07:17:04 Roger Leigh wrote:
> > > On Thu, Dec 10, 2009 at 09:38:08PM -0500, Andres Mejia wrote:
> > > > First I would like to say, thank you for reviewing my patches. :)
> > > >
> > > > Next I would like to say, please don't attach any patches inline
> > > > anymore. I spent way too much time ripping out the patch from my
> > > > email client and then had to properly format the patch just to get it
> > > > to apply.
> > >
> > > Thanks for the updated patch.  I've attached what I currently have, but
> > >  I've not yet merged all of your changes into it yet.
> > >
> > > This applies after my first patch (it replaces the second patch).
> > >
> > >
> > > Regards,
> > > Roger
> >
> > It didn't apply cleanly for me. I noticed the first hunk from the two
> > patches adds "use Sbuild::ChrootRoot;", so I figure there's already some
> > problem with the patch. I'll just wait until it's applied to the git tree
> > rather than attempt to fix the patch again. I'll report problems then.
> 
> I've put all the current changes at
>   git://git.debian.org/users/rleigh/sbuild.git
> branch "debuild-am"
> 
> It's working for me so far.
> 
> > One thing I found wrong was the pipe_command() call for
> > dpkg-parsechangelog. The hash needs to have 'DIR => getcwd()', else it
> > will fail.
> 
> I think this was caused by something else, since getcwd() is the
> default.  It's working for me without this.

I don't know why, but for some reason, it wants to default to using "/" as DIR 
in my system. I've even tried this on a pure checkout of the debuild-am 
branch. I am running this through Debian sid, if that helps. I've attached the 
patch that fixes this for me.

> 
> WRT the running external commands, I think prefer the
> "hashref of arrayrefs of arrayrefs" you discussed in your
> earlier post.  If you are happy with this, I think that's
> the way to go.

I'm fine with using either data structure.

> 
> Regards,
> Roger
> 

-- 
Regards,
Andres
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-pipe_command-call-to-dpkg-parsechangelog.patch
Type: text/x-patch
Size: 662 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20091212/d8e034a2/attachment.bin>