[buildd-tools-devel] Filesystem union v3

[Roger Leigh]

In sbuild::session:

chroot_plain *plain = dynamic_cast<chroot_plain *>(chroot.get());
#ifdef SBUILD_FEATURE_UNION
chroot_union *fsunion = dynamic_cast<chroot_union *>(chroot.get());
#endif // SBUILD_FEATURE_UNION
if (chroot->get_mount_location().empty() && plain != 0
#ifdef SBUILD_FEATURE_UNION
    && (fsunion == 0 || !fsunion->get_union_configured())
#endif // SBUILD_FEATURE_UNION
    )
  {
    log_debug(DEBUG_NOTICE) << "Setting mount location" << endl;
    std::string location(std::string(SCHROOT_MOUNT_DIR) + "/" +
			 this->session_id);
    chroot->set_mount_location(location);
  }

So, if the mount location has not already been set AND we are
NOT a plain chroot, we set the mount location.  However, what
is the point of the union logic here.  If both these
conditions are true, why would we NOT want to set it if
union is configured?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.