[buildd-tools-devel] schroot filesystem union support

[Jan-Marek Glogowski]

On Sat, 28 Mar 2009, Roger Leigh wrote:

> [PATCH 05/22] Use 'make -C' and 'mkdir -p' in debian/rules
>
> mkdir -p not necessary since debian dir always exists

The "problem" is not the parent directory, but mkdir complains and fails,
if the directory already exists.

I'm building my packages using "fakeroot debian/rules binary, which always
"complains" about the existing debian/build directory.

> [PATCH 06/22] Adapt boostrap from libtoolize suggestions.
>
> ACLOCAL_AMFLAGS OK.
> AC_CONFIG_MACRO_DIR not present, but does the same job as ACLOCAL_AMFLAGS,
> is undocumented and should probably not be used (deprecated?).
> autom4te.cache removal is unnecessary?  Seems fast enough without, so
> should be OK.

I'm using libtoolize 2.2.4.  All changes are suggested by libtoolize.

> [PATCH 08/22] Add another error detail and add log info functions.
>
> Check spelling and grammar of doxygen comments.

> ==> Commotted error changes with minor whitespace/indentation cleanup
>
> Log function log_exception() makes no time/space saving over
> existing implementation in switch statement.  This adds an extra
> layer of complexity and indirection, without any additional benefit.
> There is a space and size saving in reason logging which is duplicated
> in all functions.  Therefore separate reason logging only into a
> separate set of functions.
>
> log_exception_info and log_ctty_exception_info are valid additions
> to the API.  However, they were not added previously because
> exceptions are by definition exceptional events which should
> be at a minimum logged as a warning.  Reason information is
> logged as an informational message.
>
> ==> Committed my own unification of reason logging
> ==> log_exception_info and log_ctty_exception_info not committed

I'm using these in the next patch (don't fail on missing schroot.conf) to
inform the user in verbose mode. As I get an exception from config.add
when the file is missing but it should neither be an error nor a warning,
I thought it's the easiest way to log it.

Jan-Marek