[buildd-tools-devel] [PATCH 2/3] General chroot container member

[Roger Leigh]

On Sun, Mar 29, 2009 at 09:38:01PM +0200, Jan-Marek Glogowski wrote:
> This drops all chroot specific setters, getters and members
> for a general chroot container member.

I don't know if you had a chance to read my second patch review
mail yet, but I would really appreciate knowing why this change
is needed.

In the rest of the original patch set, I don't see a single
user of the generalised get_container() in the code, or
CHROOT_CONTAINER in the setup scripts.  As a result, I am not
certain what the generalisation is actually /for/.

If it dropped all of the chroot-specific variables in the
setup scripts I might understand it (though maybe not necessarily
agree!), but I don't see the reason.  I'm all for generalising
things, but in this case I need convincing it's cleaner (and the
get_chroot_strings in the following patch is not IMO cleaner or
more efficient than the current implementation).


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20090329/5bdb7689/attachment.pgp