[buildd-tools-devel] Bug#500746: Bug#500746: [PATCH] add --setup-hook to run in chroot before build

Kees Cook kees at debian.org
Tue May 12 19:11:28 UTC 2009


On Tue, May 12, 2009 at 08:03:32PM +0100, Roger Leigh wrote:
> Applied, thanks.  I made the following minor change:
> Used run_command rather than pipe_command because we just feed the
> pipe to the log (which is what run_command does by itself).

\o/  Great!

> I also added the configuration $setup_hook to sbuild.conf and
> documented the option in the man page.
> 
> It might be worth renaming $setup_hook to $chroot_setup_script
> in order to make the configuration file more obvious to understand.

That's fine by me.  Would the command-line argument remain --setup-hook?
I'm totally open to naming either to whatever makes sense.  I used
--setup-script originally, but Lucas had suggested --hook, so I moved
it to --setup-hook.  I'm not attached to anything specific.  :)

-Kees

-- 
Kees Cook





More information about the Buildd-tools-devel mailing list