[buildd-tools-devel] Bug#528963: Bug#528963: schroot: copyfile does not expand variables

[Roger Leigh]

On Sat, May 16, 2009 at 08:08:47PM +0200, Detlef Vollmann wrote:
> Package: schroot
> Version: 1.2.2
> Severity: wishlist
>
> Sometimes I want to copy user specific files.
> Instead of hardcoding the username in the respective copyfiles list,
> I'd like to use ${AUTH_USER}.
> With the attached patch, this works.

Thanks for the patch.

I'm not really sure if this is something we should be allowing.
It exposes internal details of how the scripts work in the configuration
files, which makes it hard to change them in the future once people
start relying on them.  I can see that it's useful, but I do want to
consider some of the long-term implications as well as its immediate
usefulness.

Is the eval strictly necessary?  Likewise the use of backticks [$() is
a better choice, by the way]?  Is there any other way of accomplishing
the same thing in the script?

Also, will this work for files with spaces in the name?


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.