[buildd-tools-devel] Bug#546555: Bug#546555: Bug#546555: sbuild: Please add support to supply remote source (.dsc) files

[Andres Mejia]

On Wednesday 16 September 2009 06:50:42 Roger Leigh wrote:
> On Mon, Sep 14, 2009 at 02:07:43PM -0400, Andres Mejia wrote:
> > I think using LWP::UserAgent should be optional to avoid a dependency on
> > libwww- perl, so here's a third patch that will allow sbuild to work with
> > or without LWP::UserAgent. Supplying a remote .dsc file will still need
> > LWP::UserAgent however.
> 
> Thanks for all the patches.  One concern I have here is if the
> complexity is really necessary?  Since we just want to check
> if a file exists and then download it, are there no existing
> Perl modules (libcurl?) that can do this more concisely and
> simply?

I took a look at WWW::Curl from CPAN at it didn't seem to be any simpler. 
Also, there doesn't seem to be proxy support through the Perl module and I 
also wanted to keep dependencies and build-dependencies at a minimum. There 
was WWW::Curl::Simple that could probably have been used but there's no 
package for that module available in the Debian archive.

In any case, I made the download() subroutine much simpler. It now takes 
advantage of the show_progress attibute from LWP::UserAgent so there's no need 
for the complicated code that was used earlier.

I also attached another patch that doesn't really relate to this bug but will 
allow messages printed to STDERR from the Sbuild::Utility subroutines to be 
duplicated into the log files. This I think is useful for the download() 
subroutine. I could supply another bug report for this one if you like.

-- 
Regards,
Andres
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Simplify-the-download-subroutine-from-Sbuild-Utility.patch
Type: text/x-patch
Size: 5165 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20090916/e7c1f06e/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Duplicate-STDOUT-and-STDERR-to-our-log-stream.patch
Type: text/x-patch
Size: 1389 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20090916/e7c1f06e/attachment-0001.bin>