[buildd-tools-devel] Bug#591620: buildd-uploader: Locking does not work on slow uplinks.

[Sebastian Andrzej Siewior]

Package: buildd
Version: 0.60.0-2
Severity: normal
Tags: patch

The following happens to people which have to upload quite a lot on a
slow uplink:
- buildd-uploader is invoked, starts the upload process and creats a
  lock named buildd-uploader.lock
- a second buildd-uploader instance is invoked. It notices the lock,
  doesn't do a thing except it kills the lock due to the following
  END statement:
  |if (defined($conf) &&
  |      defined($uploader) &&
  |      defined($uploader->get('Uploader Lock')));

  'Uploader Lock' is defined at this point but it is 0 because this
  instance does not own the lock
- a third instance of buildd-uploader is invoked which will upload
  packages.

The patch attached fixes the issue.

Sebastian