[buildd-tools-devel] Bug#605939: Regression: Chroots with periods in the name no longer work.

[Nelson Elhage]

Package: schroot
Version: 1.4.14-1
Severity: important
Tags: patch


As of schroot commit 8c1c93708397bc08519a9415da96fbdd9e26315e
(released with version 1.4.9), chroots with periods in their name no
longer work.

I personally find chroot names with dots useful, since I keep chroots
around as build/test environments for different versions of various
pieces of software, and I name them after the software version
(x.y.z).

I've attached a patch which adds '.' back in to is_valid_sessionname.

-- System Information:
Debian Release: 5.0.6
  APT prefers stable
  APT policy: (700, 'stable'), (400, 'testing'), (300, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.26-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages schroot depends on:
ii  libboost-filesystem1.42.0 1.42.0-4       filesystem operations (portable pa
ii  libboost-program-options1 1.42.0-4       program options library for C++
ii  libboost-regex1.42.0      1.42.0-4       regular expression library for C++
ii  libboost-system1.42.0     1.42.0-4       Operating system (e.g. diagnostics
ii  libc6                     2.7-18lenny6   GNU C Library: Shared libraries
ii  libgcc1                   1:4.3.2-1.1    GCC support library
ii  liblockdev1               1.0.3-1.2+b1   Run-time shared library for lockin
ii  libpam0g                  1.0.1-5+lenny1 Pluggable Authentication Modules l
ii  libstdc++6                4.4.5-4        The GNU Standard C++ Library v3
ii  libuuid1                  2.17.2-3.3     Universally Unique ID library
ii  schroot-common            1.4.14-1       common files for schroot

schroot recommends no packages.

Versions of packages schroot suggests:
ii  aufs-modules- 2.6.26+0+20080719-6+lenny3 Stackable unification filesystem f
pn  btrfs-tools   <none>                     (no description available)
ii  debootstrap   1.0.10lenny1               Bootstrap a basic Debian system
ii  lvm2          2.02.39-8                  The Linux Logical Volume Manager
ii  unzip         5.52-12                    De-archiver for .zip files

-- no debconf information

*** /tmp/0001-Make-is_valid_session_name-accept-names-with-periods.patch
>From ab1d3e2947c1cbda3f7656db3d4b35c1f9a8bd7d Mon Sep 17 00:00:00 2001
From: Nelson Elhage <nelhage at ksplice.com>
Date: Sat, 4 Dec 2010 15:13:40 -0500
Subject: [PATCH] Make is_valid_session_name accept names with periods in them.

In particular, is_valid_filename allows periods in chroot names, and such chroot
names used to work. Update is_valid_session_name so that they continue working.
---
 sbuild/sbuild-util.cc |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/sbuild/sbuild-util.cc b/sbuild/sbuild-util.cc
index add970c..32e2ec8 100644
--- a/sbuild/sbuild-util.cc
+++ b/sbuild/sbuild-util.cc
@@ -174,7 +174,7 @@ sbuild::is_valid_sessionname (std::string const& name)
 {
   bool match = false;
 
-  static regex file_namespace("^[a-zA-Z0-9][a-zA-Z0-9_-]*$");
+  static regex file_namespace("^[a-zA-Z0-9.][a-zA-Z0-9_.-]*$");
 
   if (regex_search(name, file_namespace)) {
     match = true;
-- 
1.7.1.31.g6297e