[buildd-tools-devel] Bug#569629: buildd: Don't go to next suite if --take fails.

[Philipp Kern]

On Fri, Feb 12, 2010 at 11:26:19PM +0100, Kurt Roeckx wrote:
> Package: buildd
> Version: 0.59.1-1~buildd20100201.2
> 
> I've just find this in the log:
> Feb 12 08:47:37 buildd[20978]: unstable: total 7 packages to build.
> Feb 12 08:47:40 buildd[20978]: Can't take alsa-tools: already taken by buildd_alpha-goedel
> Feb 12 08:47:44 buildd[20978]: lenny-volatile: total 0 packages to build.
> Feb 12 08:47:48 buildd[20978]: etch-volatile: total 0 packages to build.
> Feb 12 08:47:52 buildd[20978]: lenny-backports: total 24 packages to build.
> Feb 12 08:47:55 buildd[20978]: Starting build (dist=lenny-backports) of gcc-4.3_4.3.4-6~bpo50+1
> 
> I've seen it do the same kind of behaviour before.  It really
> shouldn't go to the next suite when --take fails, it should
> just try the next package in the list of packages it got.

After a discussion on IRC the MAINLOOP in Buildd::Daemon::run should be changed
to:

 1) Get rid of @todo and @lowprio_todo.  We only look at one package nowadays
    and it should thus use $pkg_ver and $low_prio_pkg_ver instead.
 2) do_wanna_build should only take $pkg_ver and return failure codes instead
    of it currently returning an empty array on failure.  On NOT OK it should
    then do $done=1, last to retry from the beginning or restart at the
    current suite.

Kind regards,
Philipp Kern

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20100221/8892804c/attachment-0001.pgp>