[buildd-tools-devel] Bug#587769: Bug#587769: schroot - Failed setup does not cleanup session

[Roger Leigh]

tags 587769 fixed-upstream pending
thanks

On Thu, Jul 01, 2010 at 04:21:45PM +0200, Bastian Blank wrote:
> Package: schroot
> Version: 1.4.5-1
> Severity: normal
> 
> A failed setup leaves a stray session file behind and makes it
> impossible to create this session again.
> 
> | $ schroot -c sid-i386 -n sid-i386-session -b
> | E: 05btrfs: ERROR: can't access to '/srv/chroot/sid/i386/user/sessions'
> | E: sid-i386-session: Chroot setup failed: stage=setup-start
> | $ schroot -c sid-i386 -n sid-i386-session -b
> | E: sid-i386-session: Failed to lock chroot: /var/lib/schroot/session/sid-i386-session: Failed to write session file: File exists

Fixed on schroot-1.4 branch.

Along with the setup script reworking for the other btrfs bug,
session cleanup now always succeeds because we ignore the
nonexistence of resources we were going to clean up anyway when
on the failure and/or cleanup paths.  The only exception to this
are resources we can't clean up such as union filesystems which
require manual intervention (an appropriate warning with
instructions is issued).


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20100704/1702a200/attachment.pgp>