[buildd-tools-devel] Bug#588550: Bug#588550: sbuild: Fails to build binNMUs for packages with urgency comments in changelogs

[Roger Leigh]

On Fri, Jul 16, 2010 at 08:41:52PM +0200, Michael Banck wrote:
> tags 588550 +patch
> thanks
> 
> On Fri, Jul 09, 2010 at 04:20:42PM +0100, Adam D. Barratt wrote:
> > The recently scheduled binNMUs of the "mandos" package failed due to a
> > problem with the auto-generated binNMU changelog; from one of the logs:
> > 
> > parsechangelog/debian: warning:     debian/changelog(l1): unrecognised line
> > LINE:  (1.0.14-1+b1) unstable; urgency=low
> > parsechangelog/debian: error: Can't call method "as_string" on an
> > undefined value at /usr/share/perl5/Dpkg/Changelog.pm line 250, <STDIN>
> > line 8.
> > 
> > This appears to be due to line 830 of lib/Sbuild/Build.pm which does:
> > 
> > $firstline =~ /^(\S+)\s+\((\S+)\)\s+([^;]+)\s*;\s*urgency=(\S+)\s*$/;
> > 
> > The most recent header line from the mandos changelog is:
> > 
> > mandos (1.0.14-1) unstable; urgency=low (HIGH on mips and mipsel)
> > 
> > Although unusual, this form is permitted by section 5.6.17 of Policy.
> 
> I propose the attached patch, which ignores the rest of the line after
> the urgency field; I can successfully binNMU mandos_1.0.14-1 with it.  I
> will probably upload the fix by the rest of weekend, if I don't hear
> complaints.

That sounds fine to me.  Please do a binNMU rather than using git
master, which currently has some issues.  Feel free to commit this
fix onto git master and buildd branches, though!


Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20100718/26963c5c/attachment.pgp>