[buildd-tools-devel] Bug#589830: Bug#589830: Bug#589830: schroot - run command produces mostly empty environment

[Roger Leigh]

tags 589830 + patch
thanks

On Wed, Jul 21, 2010 at 05:00:27PM +0100, Roger Leigh wrote:
> On Wed, Jul 21, 2010 at 05:44:57PM +0200, Bastian Blank wrote:
> > On Wed, Jul 21, 2010 at 03:24:37PM +0100, Roger Leigh wrote:
> > > On Wed, Jul 21, 2010 at 02:56:31PM +0200, Bastian Blank wrote:
> > > > The important variables TERM and SHELL are missing and breaks normal
> > > > shell usage.
> > > Using --preserve-environment (or setting preserve-environment=true
> > > in the chroot configuration) will preserve these variables.  Maybe
> > > we also need to add a whitelist in addition to the blacklist which
> > > automatically copies certain variables whether or not
> > > --preserve-environment is used?
> > 
> > You want to say that it is broken by default now, without even a note?
> 
> I'll need to double check when I have some more time, but I wasn't
> aware this was a regression.  If it is a regression, then I'll fix it.
> The environment handling was changed in the last month to move it out
> of the PAM authentication code, and if it has regressed then this will
> be the cause.  [The PAM code doesn't have testsuite coverage due to
> needing to be run as root and is rather frustrating to test robustly.]
> 
> Either way, a whitelist would remove any hardcoded preservation logic
> that was previously present and allow user customisation if desired.

Does the attached patch correct this misbehaviour?

Thanks,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: schroot-auth-minimal-env-preserve.patch
Type: text/x-diff
Size: 1363 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20100721/1bb786bd/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20100721/1bb786bd/attachment-0001.pgp>